cleanups: whitespaces; checks for mandatory fields

[darcs-mirror-metainit.git] / create-sysvinit-file.pl

diff --git a/create-sysvinit-file.pl b/create-sysvinit-file.pl
index 72c7bcf..e9e3839 100644 (file)
--- a/create-sysvinit-file.pl
+++ b/create-sysvinit-file.pl
@@ -23,7 +23,7 @@ EOF
 print "# Riequired-Start:   " . join(" ",@{$initparams{"Required-Start"}}) . "\n";
 print "# Required-Stop:     " . join(" ",@{$initparams{"Required-Stop"}}) . "\n";
 print "# Description:       ";
-print join("\n#                    ",split("\n",$initparams{"Description"}));
+print join("\n#                    ",split("\n",$initparams{"Description"})). "\n";
 print "\n";
 
 print << "EOF"
@@ -36,10 +36,10 @@ print << "EOF"
 
 # PATH should only include /usr/* if it runs after the mountnfs.sh script
 PATH=/sbin:/usr/sbin:/bin:/usr/bin
-DESC=$initparams{"Desc"}
+DESC="$initparams{"Desc"}"
 NAME=$initparams{"Name"}
 DAEMON=$initparams{"Path"}
-DAEMON_ARGS=$initparams{"Args"}
+DAEMON_ARGS="$initparams{"Args"}"
 PIDFILE=/var/run/\$NAME.pid
 SCRIPTNAME=/etc/init.d/\$NAME
 EOF
@@ -66,13 +66,22 @@ print << 'EOF'
 #
 do_start()
 {
+EOF
+;
+
+if($initparams{"Prestart-Hook"}) {
+    print "\t" . join("\n\t",split("\n",$initparams{"Prestart-Hook"}));
+    print "\n";
+}
+
+print << 'EOF'
        # Return
        #   0 if daemon has been started
        #   1 if daemon was already running
        #   2 if daemon could not be started
-       start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON --test > /dev/null \
+       start-stop-daemon --start --background --quiet --pidfile $PIDFILE --exec $DAEMON --test > /dev/null \
                || return 1
-       start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON -- \
+       start-stop-daemon --start --background --quiet --pidfile $PIDFILE --exec $DAEMON -- \
                $DAEMON_ARGS \
                || return 2
        # Add code here, if necessary, that waits for the process to be ready
@@ -103,6 +112,15 @@ do_stop()
        [ "$?" = 2 ] && return 2
        # Many daemons don't delete their pidfiles when they exit.
        rm -f $PIDFILE
+EOF
+;
+
+if($initparams{"Poststop-Hook"}) {
+    print "\t" . join("\n\t",split("\n",$initparams{"Poststop-Hook"}));
+    print "\n";
+}
+
+print << 'EOF';
        return "$RETVAL"
 }