Bug 540951 – The gnome-pty-helper is spawn when its not needed

	* src/pty.c: (_vte_pty_open): Don't use the pty helper when we don't
	need to update any of utmp, wtmp, lastlog. Patch by Alex Cornejo.

svn path=/trunk/; revision=2233

diff --git a/ChangeLog b/ChangeLog
index ec178e4..ed6c299 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-11-30  Christian Persch  <chpe@gnome.org>
+
+       Bug 540951 – The gnome-pty-helper is spawn when its not needed
+       
+       * src/pty.c: (_vte_pty_open): Don't use the pty helper when we don't
+       need to update any of utmp, wtmp, lastlog. Patch by Alex Cornejo.
+
 2008-11-30  Christian Persch  <chpe@gnome.org>
 
        Bug 465036 – gnome-pty-helper locks /var/run/utmp

diff --git a/src/pty.c b/src/pty.c
index 8ae9d47..81c338e 100644 (file)
--- a/src/pty.c
+++ b/src/pty.c
@@ -998,7 +998,7 @@ _vte_pty_open(pid_t *child_pid, char **env_add,
        }
        g_assert(op >= 0);
        g_assert(op < G_N_ELEMENTS(opmap));
-       if (ret == -1) {
+       if (ret == -1 && op != 0) {
                ret = _vte_pty_open_with_helper(&child, env_add, command, argv,
                                                directory,
                                                columns, rows, opmap[op]);